changed int_max_str_digits from -1 to 4300 to be more cpython complient #5343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did the Strange, I only changed one number, to meet the spec. |
|
You need to look in each test details to get more idea. You actually fixed it! |
|
@youknowone checks have passed, think this can be merged. :) |
fanninpm
approved these changes
Jun 27, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A basic fix, which changes sys.flags.int_max_str_digits to
4300instead of-1so it behaves the same as the cpython implementation. Fixes #5139PS: this is my first issue and I am new here, do let me know if I missed anything.