[WASM] Fix snippet selector's default selection #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 48.08% 48.08%
=======================================
Files 70 70
Lines 14500 14500
Branches 3624 3624
=======================================
Hits 6972 6972
Misses 5665 5665
Partials 1863 1863Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, on https://rustpython.github.io/demo, all of the
options have theselectedattribute, so it goes with the last one,mandelbrot, which takes a long time to run and freezes the page. I'd recommend merging this toreleaseso that that issue gets fixed in "production" ASAP.Edit: it actually does run
fibonaccifirst, but showsmandelbrotas selected, since the default snippet in the textarea is separate from theselect, but it's still an issue.