Skip to content

Conversation

OddCoincidence
Copy link
Contributor

This adds support for !a, !s, and !r in f-strings, which perform conversions prior to formatting. Note that !a is parsed but not implemented because we don't have the ascii builtin function yet.

@OddCoincidence OddCoincidence force-pushed the joey/f-string-conversion-flags branch from 7b51357 to ddc154a Compare February 24, 2019 22:38
@codecov-io
Copy link

codecov-io commented Feb 24, 2019

Codecov Report

Merging #538 into master will decrease coverage by 0.4%.
The diff coverage is 70.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
- Coverage   48.08%   47.67%   -0.41%     
==========================================
  Files          70       71       +1     
  Lines       14500    14610     +110     
  Branches     3624     3649      +25     
==========================================
- Hits         6972     6966       -6     
- Misses       5665     5778     +113     
- Partials     1863     1866       +3
Impacted Files Coverage Δ
parser/src/parser.rs 43.63% <ø> (-15.16%) ⬇️
parser/src/ast.rs 31.07% <0%> (-0.36%) ⬇️
vm/src/frame.rs 46.44% <25%> (-1.11%) ⬇️
vm/src/bytecode.rs 39.64% <33.33%> (-1.43%) ⬇️
vm/src/compile.rs 46.17% <75%> (-0.15%) ⬇️
parser/src/fstring.rs 75.42% <75.42%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205bfb7...f050acb. Read the comment docs.

@OddCoincidence OddCoincidence force-pushed the joey/f-string-conversion-flags branch from ae8145d to f050acb Compare February 25, 2019 05:13
@windelbouwman
Copy link
Contributor

Wow, formatting is pretty weird actually :)

@windelbouwman windelbouwman merged commit 9e03b69 into master Feb 25, 2019
@windelbouwman windelbouwman deleted the joey/f-string-conversion-flags branch March 23, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants