Fix copysign behavior for NaNs #5396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faf867b to
619d1e3
Compare
|
The failure in test_re seems independent of the pr as it is also failing on main. |
|
Thank you for checking! |
|
#5398 fixed test_re failure. Could you please rebase it? |
This allows enabling a bunch of tests regarding nans in test_complex, test_decimal and test_float
f074356 to
380ffdf
Compare
|
Done |
youknowone
approved these changes
Sep 11, 2024
sadboy
pushed a commit
to sdf-labs/RustPython
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows enabling test_constructor_negative_nans_from_string