Fix set intersection_update implementation #5405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation had multiple bugs:
set
intersection_update
,difference_update
,symmetric_difference_update
should check self is equal to given arg #3881,&=
and-=
operator between Set types do not work correctly. #3992 )The new implementation uses the approach chosen by cpython, i.e., create a normal intersection and then replace
self
with the result.Allows turning on one test in
test_weakset
. The equivalent test intest_set
still fails due to some of the other set operations also being buggy on self application.