Skip to content

Improve posixsubprocess #5406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

coolreader18
Copy link
Member

Fills in most of what was missing in posixsubprocess, so gids, groups, uids, etc are properly handled now.

@coolreader18 coolreader18 force-pushed the improve-posixsubprocess branch 3 times, most recently from 04626d1 to 8da64b2 Compare September 19, 2024 23:58
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please check the names

target_os = "openbsd",
target_vendor = "apple",
))]
let fd_dir_name = c"/dev/fd";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coolreader18 coolreader18 force-pushed the improve-posixsubprocess branch from 8da64b2 to 7933eda Compare September 22, 2024 03:40
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 0785cc5 into RustPython:main Sep 22, 2024
11 checks passed
@coolreader18 coolreader18 deleted the improve-posixsubprocess branch September 22, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants