Skip to content

Remove dependency on proc-macro-crate #5413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

Remove dependency on proc-macro-crate #5413

merged 1 commit into from
Sep 23, 2024

Conversation

crazymerlyn
Copy link
Contributor

This dependency is only useful when modifying the crate name of num_enum crate (https://github.com/illicitonion/num_enum/blob/86d359f430ecd12be4d544f55bc68c27a3cda82f/num_enum_derive/src/parsing.rs#L545-L550). RustPython doesn't do that so it's unnecessary.

Gets rid of some transitive dependencies like toml_edit, toml_datetime and nom8 as well.

@crazymerlyn
Remove dependency on proc-macro-crate
d1f95f0 
This dependency is only useful when modifying the crate name of
`num_enum` crate. RustPython doesn't do that so it's unnecessary.
coolreader18
coolreader18 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@coolreader18 coolreader18 merged commit d6c1e08 into RustPython:main Sep 23, 2024
11 checks passed
@crazymerlyn crazymerlyn deleted the remove-proc-macro-crate branch September 23, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crazymerlyn @coolreader18