Make stdio a feature #5420
Make stdio a feature #5420
Conversation
When embedding RustPython into a graphical windows application (where windows_subsystem = "windows"), it fails to create the RustPython VM. This happens because the VM will try to open stdin/stdout/stderr when initializing, but stdio isn't available for /SUBSYSTEM:WINDOWS apps. This commit makes stdio a feature, so it can be disabled when needed. https://doc.rust-lang.org/reference/runtime.html#the-windows_subsystem-attribute https://learn.microsoft.com/en-us/cpp/build/reference/subsystem-specify-subsystem?view=msvc-170 https://asawicki.info/news_1768_ways_to_print_and_capture_text_output_of_a_process
|
Probably a better solution would be to implement the |
|
Although for now, this is probably blocking you, so a feature flag is fine. Could you make it an off-by-default |
|
Since |
It makes sense, but wouldn't it make it mandatory to create a console to run the VM? I guess we could go to this route, which would fix using RustPython with win32 GUI apps, but I think it would still be nice to have a feature to control if we want a console to be created. For us, at least, we don't want the user to see the console, as the python code is only used to embed dynamic logic inside our app. I'm open to do any changes you guys find necessary! |
e8d8474 to
28b97b9
Compare
More in line with what CPython does
|
Changed it to set stdios to None, as I found that some imports would fail (ex: subprocess) if not set, and that seems to be an expected value (CPython expects stdin/stdout/stderr to be TextIO or None). It is possible for the user to still set the stdios to a custom file if needed, after initializing the vm: |
|
@coolreader18 could you follow this up? I am not good at windows dev |
|
Did a manual squash-merge (dabd93c) - sorry again for the delay! |
When embedding RustPython into a graphical windows application (where windows_subsystem = "windows"), it fails to create the RustPython VM.
This happens because the VM will try to open stdin/stdout/stderr when initializing, but stdio isn't available for /SUBSYSTEM:WINDOWS apps.
This commit makes stdio a feature, so it can be disabled when needed.
https://doc.rust-lang.org/reference/runtime.html#the-windows_subsystem-attribute
https://learn.microsoft.com/en-us/cpp/build/reference/subsystem-specify-subsystem?view=msvc-170 https://asawicki.info/news_1768_ways_to_print_and_capture_text_output_of_a_process