Update fstring from v3.12.7 #5444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
requested changes
Dec 2, 2024
Lib/test/test_fstring.py
Outdated
| @@ -329,13 +334,13 @@ def test_ast_line_numbers_multiline_fstring(self): | |||
| self.assertEqual(t.body[1].lineno, 3) | |||
| self.assertEqual(t.body[1].value.lineno, 3) | |||
| self.assertEqual(t.body[1].value.values[0].lineno, 3) | |||
| self.assertEqual(t.body[1].value.values[1].lineno, 3) | |||
| self.assertEqual(t.body[1].value.values[2].lineno, 3) | |||
| # TODO: RUSTPYTHON self.assertEqual(t.body[1].value.values[1].lineno, 4) | |||
There was a problem hiding this comment.
we usually do not comment out test lines, but turn off the test itself.
Could you revert this part and mark test_ast_line_numbers_multiline_fstring as expectedFailure?
add expectedFailure to tag what should rustpython do add comment for some syntaxerror which make test run broken
164bf6e to
40a9dda
Compare
key262yek
commented
Dec 5, 2024
Comment on lines
+700
to
+701
| # TODO: RUSTPYTHON SyntaxError | ||
| # self.assertEqual(f'{' f'}', " f") |
There was a problem hiding this comment.
I can't remove some comments, because it makes SyntaxError before test runs (so it cannot be passed by expectedFailure)
There was a problem hiding this comment.
Ah, that makes sense. Thank you
Comment on lines
+761
to
+769
| # TODO: RUSTPYTHON SyntaxError | ||
| # self.assertEqual( | ||
| # f""" | ||
| # # this is not a comment | ||
| # { # the following operation it's | ||
| # 3 # this is a number | ||
| # * 2}""", | ||
| # "\n# this is not a comment\n6", | ||
| # ) |
Comment on lines
+839
to
+842
| # TODO: RUSTPYTHON SyntaxError | ||
| # self.assertEqual( | ||
| # f"result: {value:{width:{0}}.{precision:1}}", "result: 12.35" | ||
| # ) |
Comment on lines
+1089
to
+1096
| # TODO: RUSTPYTHON SyntaxError | ||
| # self.assertEqual( | ||
| # f"{( | ||
| # 1 + | ||
| # 2 | ||
| # )}", | ||
| # "3", | ||
| # ) |
Comment on lines
+1266
to
+1277
| # TODO: RUSTPYTHON SyntaxError | ||
| # def test_expressions_with_triple_quoted_strings(self): | ||
| # self.assertEqual(f"{'''x'''}", 'x') | ||
| # self.assertEqual(f"{'''eric's'''}", "eric's") | ||
|
|
||
| # Test concatenation within an expression | ||
| # TODO: RUSTPYTHON self.assertEqual(f'{"x" """eric"s""" "y"}', 'xeric"sy') | ||
| # TODO: RUSTPYTHON self.assertEqual(f'{"x" """eric"s"""}', 'xeric"s') | ||
| # TODO: RUSTPYTHON self.assertEqual(f'{"""eric"s""" "y"}', 'eric"sy') | ||
| # TODO: RUSTPYTHON self.assertEqual(f'{"""x""" """eric"s""" "y"}', 'xeric"sy') | ||
| # TODO: RUSTPYTHON self.assertEqual(f'{"""x""" """eric"s""" """y"""}', 'xeric"sy') | ||
| # TODO: RUSTPYTHON self.assertEqual(f'{r"""x""" """eric"s""" """y"""}', 'xeric"sy') | ||
| # # Test concatenation within an expression | ||
| # self.assertEqual(f'{"x" """eric"s""" "y"}', 'xeric"sy') | ||
| # self.assertEqual(f'{"x" """eric"s"""}', 'xeric"s') | ||
| # self.assertEqual(f'{"""eric"s""" "y"}', 'eric"sy') | ||
| # self.assertEqual(f'{"""x""" """eric"s""" "y"}', 'xeric"sy') | ||
| # self.assertEqual(f'{"""x""" """eric"s""" """y"""}', 'xeric"sy') | ||
| # self.assertEqual(f'{r"""x""" """eric"s""" """y"""}', 'xeric"sy') |
There was a problem hiding this comment.
I think this part is the reason why I commented line by line of broken assertion at first.
Only one assertion can be run, and others make SyntaxError
youknowone
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update test_fstring.py from CPython v3.12.7