Skip to content

Move log message to the debug level #5447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

Move log message to the debug level #5447

merged 1 commit into from
Nov 27, 2024

Conversation

isbm
Copy link
Contributor

@isbm isbm commented Nov 26, 2024

When embedding and using logging facility, this log message interferes and pollutes the log with useless information. Specifically, this happens on vm.run_code_obj(obj, scope). Example:

[26/11/2024 21:15:47] - INFO: Exception raised: PyBaseException with cause: None
[26/11/2024 21:15:47] - INFO: Exception raised: PyBaseException with cause: None
[26/11/2024 21:15:47] - INFO: Exception raised: PyBaseException with cause: None
[26/11/2024 21:15:47] - INFO: Exception raised: PyBaseException with cause: None
[26/11/2024 21:15:47] - INFO: Exception raised: PyBaseException with cause: None
[26/11/2024 21:15:47] - INFO: Exception raised: PyBaseException with cause: None
[26/11/2024 21:15:47] - INFO: Exception raised: PyBaseException with cause: None
[26/11/2024 21:15:47] - INFO: Exception raised: PyBaseException with cause: None
[26/11/2024 21:15:47] - INFO: Exception raised: PyBaseException with cause: None

While there probably is a reason for it, it still should be moved to either ERROR/WARNING level with a clear indication what's wrong, or moved to the debug level.

@cclauss cclauss mentioned this pull request Nov 27, 2024
Closed
coolreader18
coolreader18 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coolreader18 coolreader18 merged commit 0c726a1 into RustPython:main Nov 27, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isbm @coolreader18