Skip to content

Complement TypeAliasType #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Jan 19, 2025

Current PR Status

Currently, this pr stuck at the part to implement new syntax introduced at 3.13 syntax.


This pull request does:

  • Bump typing module to 3.13.1.
    • Implement _typing.NoDefault
  • Complement TypeAliasType
    • Set PyTypeFlags::IMMUTABLETYPE for TypeAliasType.
    • Correct TypeAliasType.__repr__ implementation.

References

@moreal moreal closed this Mar 9, 2025
@youknowone
Copy link
Member

was there problems?

@moreal
Copy link
Contributor Author

moreal commented Mar 10, 2025

was there problems?

@youknowone I was doing some yak-shaving to bump the typing module, and then I wanted to bump the RustPython parser, and this is where I realized my lack of understanding of the PEPs involved and my lack of understanding of the underlying parser (compiler).

Due to personal situation, I'm a bit confused about my study priorities and lack motivation.

At the same time, new PR (#5590) had opened and I didn't want it to look like someone was working on them, so I closed PRs to avoid confusion.

@youknowone
Copy link
Member

Thank you for sharing. Could you keep this opened until this feature is fully implemented to let other contributors can refer it for their work?

@moreal
Copy link
Contributor Author

moreal commented Mar 10, 2025

No problem 👌🏻

@moreal moreal reopened this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants