Skip to content

Write message for todo! macro #5504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Write message for todo! macro #5504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions compiler/codegen/src/compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,8 +1095,12 @@ impl Compiler {
self.store_name(name.as_ref())?;
}
}
located_ast::TypeParam::ParamSpec(_) => todo!(),
located_ast::TypeParam::TypeVarTuple(_) => todo!(),
located_ast::TypeParam::ParamSpec(_) => {
todo!("implement Compiler::compile_type_params for TypeParam::ParamSpec")
}
located_ast::TypeParam::TypeVarTuple(_) => {
todo!("implement Compiler::compile_type_params for TypeParam::TypeVarTuple")
}
};
}
emit!(
Expand Down
8 changes: 6 additions & 2 deletions compiler/codegen/src/symboltable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,8 +1257,12 @@ impl SymbolTableBuilder {
self.scan_expression(binding, ExpressionContext::Load)?;
}
}
ast::located::TypeParam::ParamSpec(_) => todo!(),
ast::located::TypeParam::TypeVarTuple(_) => todo!(),
ast::located::TypeParam::ParamSpec(_) => {
todo!("implement SymbolTableBuilder::scan_type_params TypeParam:::ParamSpec")
}
ast::located::TypeParam::TypeVarTuple(_) => {
todo!("implement SymbolTableBuilder::scan_type_params TypeParam:::TypeVarTuple")
}
}
}
Ok(())
Expand Down
8 changes: 6 additions & 2 deletions stdlib/src/csv.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,12 @@ mod _csv {
QuoteStyle::All => csv_core::QuoteStyle::Always,
QuoteStyle::Nonnumeric => csv_core::QuoteStyle::NonNumeric,
QuoteStyle::None => csv_core::QuoteStyle::Never,
QuoteStyle::Strings => todo!(),
QuoteStyle::Notnull => todo!(),
QuoteStyle::Strings => {
todo!("implement From<QuoteStyle> for csv_core::QuoteStyle::Strings")
}
QuoteStyle::Notnull => {
todo!("implement From<QuoteStyle> for csv_core::QuoteStyle::Notnull")
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion vm/src/builtins/bool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ impl PyPayload for PyBool {

impl Debug for PyBool {
fn fmt(&self, _f: &mut Formatter<'_>) -> std::fmt::Result {
todo!()
todo!("implement Debug::fmt for PyBool")
}
}

Expand Down
Loading