[WASM] Keep a PyObjectWeakRef to the PyObjectRef being moved to a closure #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
==========================================
+ Coverage 41.15% 41.23% +0.07%
==========================================
Files 74 75 +1
Lines 16921 17105 +184
Branches 4471 4538 +67
==========================================
+ Hits 6964 7053 +89
- Misses 7929 8014 +85
- Partials 2028 2038 +10
Continue to review full report at Codecov.
|
|
@windelbouwman could you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mechanism could also be generalized to other
Rc-held types that we need to keep for the lifetime of the VM, as I left open in the code.