No panic on symbol lookup fail #5555
Conversation
| @@ -33,6 +33,7 @@ pub enum CodegenErrorType { | |||
| DuplicateStore(String), | |||
| InvalidMatchCase, | |||
| NotImplementedYet, // RustPython marker for unimplemented features | |||
| SymbolLookupError { symbol: String }, | |||
There was a problem hiding this comment.
Because this is not a user-side Python error but our own RustPython implementation bug, let's not expose it here.
|
Do you have a repr for this getting triggered? The reason it's a panic is because this shouldn't ever happen, the symboltable should be populated with every identifier present in the source file even if it would be a NameError at runtime. It should really be an |
|
Makes sense, this occurs because I implemented match statements poorly. I feel like the instruction set to be upgraded to 3.12 before match statements are attempted so there is a better feel for specialized instructions. I'll get an minimal example that triggers this working soon. |
|
Interestingly enough #5494 runs into this as well for unrelated reasons. |
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
98c8b40 to
aeb9715
Compare
|
I have found a superior solution |
No description provided.