fix io module being initialized multiple times #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
- Coverage 43.19% 43.14% -0.05%
==========================================
Files 72 72
Lines 15893 15899 +6
Branches 4172 4176 +4
==========================================
- Hits 6865 6860 -5
- Misses 7106 7117 +11
Partials 1922 1922
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #557.
I wanted to test it somehow, but I am not sure how and whether I really should. Other modules are not tested for being imported once, and this one needs opening (ie. creating) a file (which is not portable to wasm, and litters user’s filesystem).