Initial C-api implementation #5604
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a41976 to
8b9ab66
Compare
|
Ready for review. |
143bb86 to
79ac3ca
Compare
|
Should I just exclude |
|
What kind of terms bother you? I disabled a few files for reasons:
When sharing a few terms with CPython implementation makes problem, adding them to cpython.txt will be better |
|
Stuff like ccomplex. I'm actually just going to add it to cspell, since it's probably better that way. |
|
Should be fixed ... ready for merge. |
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't aim to implement any particular feature set/subset of the C-API, rather it tries to get the scaffolding in place, so that most functions could be implemented.
It's currently built as a dll/so, but it probably needs to be renamed later on (packaging this kind of this is not my area of expertise).
This PR implements large parts of the concrete objects layer and a stub for error handling, although it needs to be expanded on.