Merge format and literal back into this repo (and update malachite) #5618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbce338 to
5570aa0
Compare
youknowone
approved these changes
Mar 22, 2025
Cargo.toml
Outdated
Comment on lines
131
to
134
| # rustpython-parser-core = { version = "0.4.0" } | ||
| # rustpython-parser = { version = "0.4.0" } | ||
| # rustpython-ast = { version = "0.4.0" } | ||
| # rustpython-format= { version = "0.4.0" } |
There was a problem hiding this comment.
Suggested change
| # rustpython-parser-core = { version = "0.4.0" } | |
| # rustpython-parser = { version = "0.4.0" } | |
| # rustpython-ast = { version = "0.4.0" } | |
| # rustpython-format= { version = "0.4.0" } |
Cargo.toml
Outdated
Comment on lines
135
to
137
| # rustpython-parser-core = { git = "https://github.com/RustPython/Parser.git", version = "0.4.0", rev = "d2f137b372ec08ce4a243564a80f8f9153c45a23" } | ||
| # rustpython-parser = { git = "https://github.com/RustPython/Parser.git", version = "0.4.0", rev = "d2f137b372ec08ce4a243564a80f8f9153c45a23" } | ||
| # rustpython-ast = { git = "https://github.com/RustPython/Parser.git", version = "0.4.0", rev = "d2f137b372ec08ce4a243564a80f8f9153c45a23" } |
There was a problem hiding this comment.
Suggested change
| # rustpython-parser-core = { git = "https://github.com/RustPython/Parser.git", version = "0.4.0", rev = "d2f137b372ec08ce4a243564a80f8f9153c45a23" } | |
| # rustpython-parser = { git = "https://github.com/RustPython/Parser.git", version = "0.4.0", rev = "d2f137b372ec08ce4a243564a80f8f9153c45a23" } | |
| # rustpython-ast = { git = "https://github.com/RustPython/Parser.git", version = "0.4.0", rev = "d2f137b372ec08ce4a243564a80f8f9153c45a23" } |
Cargo.toml
Outdated
Comment on lines
138
to
140
| # rustpython-literal = { path = "../RustPython-parser/literal" } | ||
| # rustpython-parser-core = { path = "../RustPython-parser/core" } | ||
| # rustpython-parser = { path = "../RustPython-parser/parser" } |
There was a problem hiding this comment.
Suggested change
| # rustpython-literal = { path = "../RustPython-parser/literal" } | |
| # rustpython-parser-core = { path = "../RustPython-parser/core" } | |
| # rustpython-parser = { path = "../RustPython-parser/parser" } |
256ac94 to
33a8cfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ruff forking off into their own parser (and now us using that instead), I don't see much of a reason to keep
Parseras its own repo, and a monorepo makes it easier to make systemic changes (e.g. #5587). Maybe we'd switch some stuff inliteralto use ruff'sruff_python_literalcrate, but if #5587 lands we'd need to have our own wtf8-based implementation anyway.I was originally gonna try to do something with
git subtreeorfilter-branchto maintain the history, but it didn't seem so worth it.