Refactor codecs #5623
Merged
Refactor codecs #5623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7554510 to
f323d14
Compare
youknowone
approved these changes
Mar 26, 2025
| } | ||
|
|
||
| #[derive(Copy, Clone, Default, Debug)] | ||
| pub struct StrSize { |
There was a problem hiding this comment.
We now have both StrSize and StrLen.
Rust always uses len for string and bytes length.
This struct is named StrSize but containing a pair of length.
Any chance this can be named better?
There was a problem hiding this comment.
I considered it similar to ruff's TextSize or even just usize. I think I want to do a follow-up to consolidate the 2 structs.
There was a problem hiding this comment.
It can contain a pair of lengths, but you could also treat them as indices, in the same way usize can be a length or an index.
| @@ -872,8 +875,8 @@ impl Wtf8 { | |||
| } | |||
| } | |||
|
|
|||
| pub fn clone_into(&self, buf: &mut Wtf8Buf) { | |||
| self.bytes.clone_into(&mut buf.bytes); | |||
| pub fn is_code_point_boundary(&self, index: usize) -> bool { | |||
There was a problem hiding this comment.
Suggested change
| pub fn is_code_point_boundary(&self, index: usize) -> bool { | |
| pub fn is_code_point_boundary_at(&self, index: usize) -> bool { |
not the whole string is boundary, but the byte of index is
There was a problem hiding this comment.
The method in std is named str::is_char_boundary
Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rejiggles some stuff around so that the situation is now:
{En,De}codeContextowns the input data and defines the error type.{En,De}codeErrorhandleris passed the context and just encapsulates the error handling behavior.rustpython_common::encodings::errorsmodule.