Skip to content

Updated test_baseexception from 3.13.2 #5638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hbina
Copy link
Contributor

@hbina hbina commented Mar 30, 2025

No description provided.

@youknowone
Copy link
Member

Is this 3.12 or also 3.13? The PR title and branch name mismatches

@hbina hbina closed this Mar 31, 2025
@youknowone
Copy link
Member

@hbina you dont need to close PRs

@hbina hbina reopened this Apr 1, 2025
@hbina hbina changed the title Updated test_baseexception from 3.12.2 Updated test_baseexception from 3.13.2 Apr 1, 2025
Signed-off-by: Hanif Ariffin <hanif.ariffin.4326@gmail.com>
@hbina hbina force-pushed the hbina-fix-py313-test-baseexception branch from 8268e79 to cebe57a Compare April 5, 2025 03:16
@youknowone
Copy link
Member

@hbina Please just check this is from 3.12 or 3.13. One of commit message or the PR title need to be changed

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I checked 3.13.2 source code and this is about 3.13.2.
Squash merge to replace commit message

@youknowone youknowone merged commit 974c54e into RustPython:main Apr 19, 2025
11 checks passed
@hbina hbina deleted the hbina-fix-py313-test-baseexception branch April 19, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants