Fix float parsing #5643
Merged
Fix float parsing #5643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fb5c87 to
14e1013
Compare
14e1013 to
d2a2120
Compare
youknowone
requested changes
Mar 31, 2025
compiler/literal/src/complex.rs
Outdated
| if re.is_sign_positive() { | ||
| return im_part; | ||
| } else { | ||
| re.to_string() |
There was a problem hiding this comment.
Suggested change
| re.to_string() | |
| "0" |
or
Suggested change
| re.to_string() | |
| "0.0" |
?
Calling specifically f64::to_string() only for zero and float::to_string(re) for non-zero looks like a bug or unnecessary
There was a problem hiding this comment.
This was copied over from the old implementation, but I agree.
youknowone
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.