Skip to content

Fix bytes.isspace #5655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix bytes.isspace #5655

wants to merge 9 commits into from

Conversation

hbina
Copy link
Contributor

@hbina hbina commented Apr 1, 2025

Fix implementation of bytes.isspace to match the implementation in CPython.

@hbina hbina changed the title Updated test_bigmem from v3.13.2 Update test_bigmem from v3.13.2 Apr 1, 2025
@youknowone youknowone changed the title Update test_bigmem from v3.13.2 Fix bytes.isspace Apr 1, 2025
youknowone
youknowone reviewed Apr 1, 2025
View reviewed changes
@hbina hbina force-pushed the hbina-fix-bytes-isspace-not-checking-other-whitespaces branch from b7308f4 to 7f9cf7d Compare April 5, 2025 03:12
@youknowone
Copy link
Member

test_bytes is not passing

======================================================================
FAIL: test_istitle (test.test_bytes.ByteArrayAsStringTest.test_istitle)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/RustPython/RustPython/pylib/Lib/test/string_tests.py", line 968, in test_istitle
    self.checkequal(False, 'Not--a Titlecase String', 'istitle')
  File "/home/runner/work/RustPython/RustPython/pylib/Lib/test/string_tests.py", line 68, in checkequal
    realresult
AssertionError: False != True

======================================================================
FAIL: test_istitle (test.test_bytes.BytesAsStringTest.test_istitle)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/RustPython/RustPython/pylib/Lib/test/string_tests.py", line 968, in test_istitle
    self.checkequal(False, 'Not--a Titlecase String', 'istitle')
  File "/home/runner/work/RustPython/RustPython/pylib/Lib/test/string_tests.py", line 68, in checkequal
    realresult
AssertionError: False != True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbina @youknowone