Use mimalloc for better performance #5678
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
reviewed
Apr 7, 2025
|
@theoparis Do you have any concern? Please leave a comment if you have opinion about it. |
|
The only concern I had was that there is no way to disable mimalloc without modifying rustpython sources after this is merged. I've encountered crashes with jemalloc and chromium's allocator when another allocator is set globally via LD_PRELOAD for example - but maybe this isn't an issue with mimalloc? Other than that I think adding mimalloc is a good idea for performance reasons 👍🏼 |
|
@theoparis Thank you for explanation. In that case, adding a mimialloc feature will be helpful, right? |
|
Not an unreasonable request. |
|
I seem to have found a fix, I think I'll just make it environment variable only for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I measured around a 10% performance improvement on pystones (better benchmarks coming soon).
Fixes: #5526