First steps towards native subclassing #5679
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ba88a8 to
4d276ea
Compare
4d276ea to
deb6022
Compare
|
The cspell errors seem to be a false positive, since it's flagging words that were there before this PR. |
|
Yeah it does that a lot. I'll send a pr in to fix it. |
|
cspell action's incremental check option doesn't look working that good |
|
Probably because it checks the entire file instead of just the changes (from what I see). |
|
The issue is it runs this command, which fails sometimes: |
youknowone
requested changes
Apr 17, 2025
| @@ -172,7 +172,7 @@ mod _bz2 { | |||
|
|
|||
| #[pyattr] | |||
| #[pyclass(name = "BZ2Compressor")] | |||
| #[derive(PyPayload)] | |||
| #[derive()] | |||
| @@ -266,8 +266,8 @@ def LoadLibrary(self, name): | |||
|
|
|||
| cdll = LibraryLoader(CDLL) | |||
|
|
|||
| test_byte_array = create_string_buffer(b"Hello, World!\n") | |||
| assert test_byte_array._length_ == 15 | |||
| # test_byte_array = create_string_buffer(b"Hello, World!\n") | |||
| if let Meta::NameValue(syn::MetaNameValue { | ||
| value: | ||
| syn::Expr::Path(syn::ExprPath { | ||
| qself: None, path, .. |
There was a problem hiding this comment.
please add qself to rust-more.txt
| /// | ||
| /// # Safety | ||
| /// | ||
| /// `type_id` must be accurate. |
There was a problem hiding this comment.
I understand wrong type_id can cause a bug, but not sure how it can make unsafety. Do you have a scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not very ergonomic yet, and there are definitely some soundness holes atm, but I aim to fix those in a follow-up.