Skip to content

Upgrade parts of test.support #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arihant2math
Copy link
Collaborator

No description provided.

@arihant2math arihant2math mentioned this pull request Apr 10, 2025
23 tasks
@youknowone
Copy link
Member

youknowone commented Apr 14, 2025

The support patches look good overall.

They remain in pending status because they primarily add new files that aren't being used anywhere yet. This means we can't fully test them right now due to lack of usage. They might not be in a fully working state.

These patches can be merged either:

  • At the final step of updating test.support
  • When other code begins to require these files

Generally, keeping patches unmerged is not ideal since conflicts gradually increase over time and patches become outdated.
However, in this specific case, since these patches are mostly adding new files (which typically don't create merge conflicts), I believe there's an exception where keeping them unmerged temporarily offers more benefits than merging them prematurely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants