Skip to content

feat: add typing.Self #5710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: add typing.Self #5710

wants to merge 1 commit into from

Conversation

starpit
Copy link

@starpit starpit commented Apr 17, 2025

No description provided.

@arihant2math
Copy link
Collaborator

Probably a good temporary fix.

See also: #5590

@youknowone
Copy link
Member

youknowone commented Apr 18, 2025

Since test_typing does not currently cover Self, please add a small test under extra_tests/snippets/stdlib_typing.py

@starpit
Copy link
Author

starpit commented Apr 18, 2025

thanks for the feedback. i agree that #5590 is a much better approach. in our case, Self is just one of many typing blockers...

@youknowone
Copy link
Member

@starpit #5590 will take more time. I am going to merge this one first if you don't mind to add a test about this patch.

@starpit
Copy link
Author

starpit commented Apr 19, 2025

fyi, #5711 is another blocker we ran into re: typing. Curious: is there some way we could offer to disable type checking?

Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
@starpit
Copy link
Author

starpit commented Apr 19, 2025

@arihant2math
Copy link
Collaborator

Closing, since other PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants