Fix test_poll::test_poll3 #5718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the failing test_poll3 by addressing the integer overflow issue and refactoring the eventmask parsing logic into a dedicated type.
- Introduces a new EventMask type and implements TryFromObject for it.
- Refactors the register and modify methods in the poll implementation to use EventMask.
- Removes the expected failure decorator from test_poll3 after the fix.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| stdlib/src/select.rs | Adds EventMask type and refactors eventmask usage. |
| Lib/test/test_poll.py | Removes the expected failure decorator for test_poll3. |
Comments suppressed due to low confidence (2)
Lib/test/test_poll.py:152
- [nitpick] With the applied fix, ensure that test_poll3 now adequately validates the overflow scenario without relying on an expected failure declaration.
# TODO: RUSTPYTHON int overflow
stdlib/src/select.rs:426
- The PR description mentioned a 'PyEventMask' wrapping a u16, but the implementation uses i16. Please verify that using i16 is intentional and aligns with the expected semantics.
pub struct EventMask(pub i16);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked github copilot chat to find one of easy to fix
TODO: RUSTPYTHONin the test files and try to fix one of them.The result with minor edits is the first commit.
Next, I asked to refactor them with:
The result with minor edits is the second commit.