Skip to content

Implement nt.listvolumes #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement nt.listvolumes #5730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions vm/src/stdlib/nt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,39 @@ pub(crate) mod module {
Ok(vm.ctx.new_list(drives))
}

#[pyfunction]
fn listvolumes(vm: &VirtualMachine) -> PyResult<PyListRef> {
let mut volumes = vec![];
let mut buffer = [0u16; 257];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is related to constant, is this possible?

Suggested change
let mut buffer = [0u16; 257];
let mut buffer = [0u16; MAX_PATH + 1];

let find = unsafe { FileSystem::FindFirstVolumeW(buffer.as_mut_ptr(), buffer.len() as _) };
if find == windows_sys::Win32::Foundation::INVALID_HANDLE_VALUE {
return Err(errno_err(vm));
}
let mut err = 0;
while err == 0 {
let s = unsafe { widestring::WideCString::from_ptr_str(buffer.as_mut_ptr()) };
let s = s.to_string_lossy();
if s.is_empty() {
break;
}
volumes.push(s.to_string());
let ret = unsafe {
FileSystem::FindNextVolumeW(find, buffer.as_mut_ptr(), buffer.len() as _)
};
if ret == 0 {
err = std::io::Error::last_os_error().raw_os_error().unwrap_or(0);
}
}
if find != windows_sys::Win32::Foundation::INVALID_HANDLE_VALUE {
unsafe { FileSystem::FindVolumeClose(find) };
}
if err != 0 && err != windows_sys::Win32::Foundation::ERROR_NO_MORE_FILES as i32 {
return Err(std::io::Error::from_raw_os_error(err).to_pyexception(vm));
}
let volumes: Vec<_> = volumes.into_iter().map(|v| vm.new_pyobj(v)).collect();
Ok(vm.ctx.new_list(volumes))
}

#[pyfunction]
fn set_handle_inheritable(
handle: intptr_t,
Expand Down Expand Up @@ -476,3 +509,4 @@ pub(crate) mod module {
Vec::new()
}
}
}
Loading