Skip to content

Replace puruspe to pymath #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Replace puruspe to pymath #5733

merged 1 commit into from
Apr 29, 2025

Conversation

youknowone
Copy link
Member

Might be lower quality, but better compatibility

Repository: https://github.com/RustPython/pymath

@youknowone
Copy link
Member Author

oh, wasm!

Copy link
Collaborator

@arihant2math arihant2math left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hopefully this leads to better compatibility

@youknowone
Copy link
Member Author

probably I'd better to use optionally use puruspe in pymath for wasm.

@arihant2math
Copy link
Collaborator

Can errno and the related macro just be conditionally disabled on wasm, that might fix the build?

@youknowone
Copy link
Member Author

Oh, for this patch, yes if wasm has erf and erfc

Might be lower quality, but better compatibility
@youknowone
Copy link
Member Author

Great, wasm32 had enough functions

@youknowone youknowone merged commit b0991e2 into RustPython:main Apr 29, 2025
11 of 22 checks passed
@youknowone youknowone deleted the pymath branch April 29, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants