chore: add ruff format --check
#5774
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e55eef to
4f14a31
Compare
4f14a31 to
6f0b586
Compare
youknowone
requested changes
May 9, 2025
| @@ -41,13 +41,15 @@ | |||
| assert c == 2 | |||
| assert d == 3 | |||
|
|
|||
| a, = [1] | |||
| (a,) = [1] | |||
There was a problem hiding this comment.
Files with syntax_ prefix is intentionally testing these kind of syntax. Please review those files not to lose this intentions
There was a problem hiding this comment.
Can't ruff be configured to ignore those lints? That would be preferable in my opinion.
There was a problem hiding this comment.
Two options here to make immediate progress:
- We can ignore syntax_*.py in
ruff.tomlentirely - We can add ruff directives to each of these
syntax_*.pyfiles to ignore formatting for the entire file. + add a TODO to refine the directive to the specific line if someone edits the file in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5773.
Summary
Add a
ruff formatstep for the Python files generated by contributors.Main file to look at here is 4f14a31#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd.
Test Plan