Skip to content

feat: implement zlib.__version__ #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

feat: implement zlib.__version__ #5776

merged 1 commit into from
May 8, 2025

Conversation

rexledesma
Copy link
Contributor

Summary

After running uv run python -I whats_left.py, I saw zlib.__version__ and thought it'd be easy to implement.

Test Plan

RustPython on ξ‚  rl/zlib-easy via 🐍 v3.13.2 via πŸ¦€ v1.86.0 
❯ cargo run --release
   Compiling radium v1.1.0 (https://github.com/youknowone/ferrilab?branch=fix-nightly#4a301c3a)
   Compiling rustpython-common v0.4.0 (/Users/rexledesma/Documents/projects/RustPython/common)
   Compiling rustpython-vm v0.4.0 (/Users/rexledesma/Documents/projects/RustPython/vm)
   Compiling rustpython-stdlib v0.4.0 (/Users/rexledesma/Documents/projects/RustPython/stdlib)
   Compiling rustpython v0.4.0 (/Users/rexledesma/Documents/projects/RustPython)
    Finished `release` profile [optimized] target(s) in 22.71s
     Running `target/release/rustpython`
Welcome to the magnificent Rust Python 0.4.0 interpreter 😱 πŸ––
RustPython 3.13.0
Type "help", "copyright", "credits" or "license" for more information.
>>>>> import zlib
>>>>> zlib.__version__
'1.0'

youknowone
youknowone approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@youknowone youknowone merged commit 9083860 into RustPython:main May 8, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexledesma @youknowone