-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix UnpackIterator constructor #5815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the Rust implementation of the Changes
Sequence Diagram(s)sequenceDiagram
participant Python
participant RustVM
participant UnpackIterator
Python->>RustVM: struct.Struct(...).iter_unpack(...)
RustVM->>UnpackIterator: UnpackIterator::with_buffer(...)
UnpackIterator-->>RustVM: returns iterator
Python->>RustVM: UnpackIterator() (direct instantiation)
RustVM-->>Python: Raises TypeError (Unconstructible)
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (9)
🔇 Additional comments (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
Bug Fixes
struct.Struct(...).iter_unpack(...)
, ensuring aTypeError
is raised as expected.Tests