Skip to content

sys.setswitchinterval #5817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

sys.setswitchinterval #5817

merged 1 commit into from
Jun 22, 2025

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Jun 22, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added functions to get and set the interpreter's thread switch interval via the system module.

  • Bug Fixes

    • Updated tests so that checks for thread switch interval settings are now treated as normal tests, not expected failures.
    • Removed expected failure markers from several threading and functools tests, improving test reliability and coverage.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 22, 2025 •
edited
Loading

Walkthrough

The changes introduce support for Python's thread switch interval configuration by adding getswitchinterval and setswitchinterval functions to the sys module, backed by a new switch_interval field in the VM state. Corresponding tests are updated to treat related cases as normal tests, removing expected failure decorators.

Changes

File(s) Change Summary
Lib/test/test_sys.py, Lib/test/test_syslog.py, Lib/test/test_functools.py, Lib/test/test_threading.py Removed @unittest.expectedFailure decorators from tests related to switch interval and threading.
vm/src/stdlib/sys.rs Added getswitchinterval and setswitchinterval functions to expose thread switch interval control.
vm/src/vm/mod.rs Added switch_interval field to PyGlobalState and initialized it in VirtualMachine::new.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant sys module
    participant VM

    User->>sys module: sys.getswitchinterval()
    sys module->>VM: Read switch_interval
    VM-->>sys module: Return float value
    sys module-->>User: Return switch interval

    User->>sys module: sys.setswitchinterval(value)
    sys module->>VM: Validate value > 0, set switch_interval
    VM-->>sys module: Success or raise ValueError
    sys module-->>User: Return or raise error
Loading

Poem

A switch interval, set with care,
Now Python threads can fairly share.
The sys module gains new might,
To get and set intervals just right.
Tests now run without dismay—
Hooray for progress, hip-hip-hooray!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4793d33 and 4dc5323.

📒 Files selected for processing (6)
  • Lib/test/test_functools.py (0 hunks)
  • Lib/test/test_sys.py (0 hunks)
  • Lib/test/test_syslog.py (0 hunks)
  • Lib/test/test_threading.py (0 hunks)
  • vm/src/stdlib/sys.rs (1 hunks)
  • vm/src/vm/mod.rs (2 hunks)
💤 Files with no reviewable changes (4)
  • Lib/test/test_syslog.py
  • Lib/test/test_threading.py
  • Lib/test/test_functools.py
  • Lib/test/test_sys.py
🚧 Files skipped from review as they are similar to previous changes (2)
  • vm/src/stdlib/sys.rs
  • vm/src/vm/mod.rs
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Run tests under miri
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Ensure compilation on various targets
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@youknowone youknowone force-pushed the sys-setswitchinterval branch from 4793d33 to 4dc5323 Compare June 22, 2025 12:40
@youknowone youknowone merged commit 5d68313 into RustPython:main Jun 22, 2025
12 checks passed
@youknowone youknowone deleted the sys-setswitchinterval branch June 22, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youknowone