relocate Generic under typevar.rs #5889

youknowone · 2025-07-03T02:35:50Z

Summary by CodeRabbit

New Features
- Introduced a new Generic class in the typing module, providing class methods for generic type handling.
Refactor
- Internal implementation of the Generic class has been reorganized for improved maintainability, with no impact on existing user functionality.

coderabbitai · 2025-07-03T02:35:56Z

Walkthrough

The changes move the implementation of the Generic class and its helper function from the typing module to the typevar module. The typing module now re-exports Generic from typevar and updates its module initialization to use the new location. No existing logic is modified; only code relocation and re-exporting occur.

Changes

Files/Paths	Change Summary
vm/src/stdlib/typevar.rs	Added `call_typing_args_kwargs` helper and new public `Generic` class with two class methods.
vm/src/stdlib/typing.rs	Removed internal `Generic` class and helper; re-exported `Generic` from `typevar`; updated module init.

Sequence Diagram(s)

sequenceDiagram
    participant PythonUser
    participant GenericClass (from typevar)
    participant TypingModule

    PythonUser->>GenericClass: __class_getitem__(args)
    GenericClass->>TypingModule: _generic_class_getitem(cls, args)

    PythonUser->>GenericClass: __init_subclass__(args)
    GenericClass->>TypingModule: _generic_init_subclass__(cls, args)

Suggested reviewers

arihant2math

Poem

In the warren of code, a shuffle anew,
Generic hops from typing, to typevar it flew.
Helpers in tow, with methods so neat,
Now re-exported, their journey complete.
From one burrow to another, the logic is sound—
In the fields of Python, new homes are found! 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Clippy (1.86.0)

Updating git repository `https://github.com/youknowone/ferrilab`

error: failed to load source for dependency radium

Caused by:
Unable to update https://github.com/youknowone/ferrilab?branch=fix-nightly#4a301c3a

Caused by:
failed to create directory /usr/local/git/db/ferrilab-ed7d38936952b47e

Caused by:
Permission denied (os error 13)

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fffa735 and 4585123.

📒 Files selected for processing (2)

vm/src/stdlib/typevar.rs (1 hunks)
vm/src/stdlib/typing.rs (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.rs`: Follow the default rustfmt code style (`cargo fmt` to format) Always ...

**/*.rs: Follow the default rustfmt code style (cargo fmt to format)
Always run clippy to lint code (cargo clippy) before completing tasks. Fix any warnings or lints that are introduced by your changes
Follow Rust best practices for error handling and memory management
Use the macro system (pyclass, pymodule, pyfunction, etc.) when implementing Python functionality in Rust

📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)

List of files the instruction was applied to:

vm/src/stdlib/typing.rs
vm/src/stdlib/typevar.rs

🧠 Learnings (2)

vm/src/stdlib/typing.rs (1)

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust

vm/src/stdlib/typevar.rs (1)

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust

⏰ Context from checks skipped due to timeout of 90000ms (11)

GitHub Check: Run rust tests (windows-latest)
GitHub Check: Run rust tests (macos-latest)
GitHub Check: Run rust tests (ubuntu-latest)
GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Ensure compilation on various targets
GitHub Check: Check the WASM package and demo
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Run tests under miri
GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Check Rust code with rustfmt and clippy
GitHub Check: Run snippets and cpython tests (ubuntu-latest)

🔇 Additional comments (4)

vm/src/stdlib/typing.rs (2)

4-6: LGTM!

The import changes correctly reflect the relocation of Generic to the typevar module, maintaining consistency with other type variable classes.

16-16: Proper module initialization and export.

The Generic class is correctly initialized and added to the module's namespace, following the established pattern for other type variable classes.

Also applies to: 24-24

vm/src/stdlib/typevar.rs (2)

952-974: Well-structured helper function for typing module delegation.

The call_typing_args_kwargs function correctly implements the pattern for delegating calls to the typing module with the class as the first argument. This maintains the expected CPython behavior.

976-997: Clean implementation of Generic class.

The Generic class implementation properly uses the pyclass macro system and correctly delegates both __class_getitem__ and __init_subclass__ to the typing module's internal functions. The BASETYPE flag is appropriately set to allow inheritance.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

relocate Generic under typevar.rs

4585123

youknowone merged commit 49422c5 into RustPython:main Jul 3, 2025
12 checks passed

youknowone deleted the relocate-generics branch July 3, 2025 03:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

relocate Generic under typevar.rs #5889

relocate Generic under typevar.rs #5889

Uh oh!

youknowone commented Jul 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 3, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

relocate Generic under typevar.rs #5889

relocate Generic under typevar.rs #5889

Uh oh!

Conversation

youknowone commented Jul 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

youknowone commented Jul 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 3, 2025 •

edited

Loading