Re module #591
Re module #591
Conversation
vm/src/stdlib/re.rs
Outdated
| pub fn mk_module(ctx: &PyContext) -> PyObjectRef { | ||
| let match_type = py_class!(ctx, "Match", ctx.object(), {}); | ||
| /// Take a found regular expression and convert it to proper match object. | ||
| fn create_match(vm: &mut VirtualMachine, match_value: Match<'static>) -> PyResult { |
There was a problem hiding this comment.
Rust expertise required on this line. I added 'static here, but is this even required / legal? The code refuses to compile as I want. I want to add Match inside a Box, but Match has a non-static lifetime :(.
There was a problem hiding this comment.
The reason rust won't compile this is because it would lead to a use-after-free - the string being passed to Regex::find is borrowed by the Match that it returns, but will be dropped at the end of do_search. Rust can tell that the Match is going to outlive the search_text string, and thus point to invalid memory, so it rejects the code.
One solution would be to create your own match type for the payload and copy what you need out of the regex match.
I hope this is helpful!
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
==========================================
+ Coverage 41.25% 44.45% +3.19%
==========================================
Files 75 75
Lines 17096 17710 +614
Branches 4538 4964 +426
==========================================
+ Hits 7053 7873 +820
+ Misses 8005 7770 -235
- Partials 2038 2067 +29
Continue to review full report at Codecov.
|
No description provided.