Skip to content

Only use real isinstance/issubclass for built-ins #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

BenLewis-Seequent
Copy link

Also moves the real versions to the vm.

This is a followup PR to #554 that resolves post-merge review comments

@codecov-io
Copy link

Codecov Report

Merging #594 into master will decrease coverage by 0.05%.
The diff coverage is 36.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
- Coverage   41.66%   41.61%   -0.06%     
==========================================
  Files          74       74              
  Lines       16768    16762       -6     
  Branches     4397     4406       +9     
==========================================
- Hits         6986     6975      -11     
- Misses       7772     7781       +9     
+ Partials     2010     2006       -4
Impacted Files Coverage Δ
vm/src/macros.rs 14.28% <ø> (ø) ⬆️
vm/src/obj/objtype.rs 38.75% <ø> (-2.33%) ⬇️
vm/src/pyobject.rs 59.67% <0%> (+0.34%) ⬆️
vm/src/obj/objsuper.rs 50% <0%> (+7.14%) ⬆️
vm/src/builtins.rs 43.84% <33.33%> (+0.15%) ⬆️
vm/src/vm.rs 51.69% <46.15%> (-1.67%) ⬇️
vm/src/stdlib/string.rs 23.03% <0%> (+1.47%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b7c0f7...b1a070a. Read the comment docs.

@cthulahoops cthulahoops merged commit 5d28f9b into RustPython:master Mar 4, 2019
@BenLewis-Seequent BenLewis-Seequent deleted the isinstance_2 branch March 29, 2019 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants