-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Set timeout for CI #5947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Set timeout for CI #5947
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeout-minutes
does not accept expressions – these jobs will fail to parsetimeout-minutes
expects a literal integer. GitHub Actions currently rejects expressions such as${{ contains(matrix.os, 'windows') && 40 || 30 }}
with a schema-validation error (expected type: integer
). As a result, bothrust_tests
andsnippets_cpython
jobs will never start.Keep the workflow simple (per maintainer guidance) by using a constant, e.g. 40 minutes for all OSes, or split the job into two OS-specific matrix entries.
(Apply the same change to the
snippets_cpython
job.)Also applies to: 242-242
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this evaluates to either 30 or 40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
@ShaharNaveh You're absolutely right! I apologize for the incorrect assessment. GitHub Actions does indeed support expressions in the
timeout-minutes
field, and your expression${{ contains(matrix.os, 'windows') && 40 || 30 }}
will correctly evaluate to 40 minutes for Windows runners and 30 minutes for other OS runners.Thank you for the correction - the workflow syntax is perfectly valid as implemented.
🌐 Web query:
💡 Result:
GitHub Actions'
timeout-minutes
does not fully support expressions like repository or environment variables without specific type conversion workarounds. Here are the facts and the current documentation status:timeout-minutes
parameter sets the maximum number of minutes a job can run before GitHub cancels it. The default is 360 minutes (6 hours), but you can increase or decrease this limit as needed within the permitted range[1][4][10].timeout-minutes
must be a numeric literal or an expression that resolves to a number. If you attempt to set it directly using a repository or environment variable (e.g.,timeout-minutes: ${{ vars.TIMEOUT }}
), you may encounter a workflow syntax error if the value is interpreted as a string or is not properly cast to a number[3].Workaround:
You can use the
fromJSON()
function to convert strings that contain numbers to a numeric value, making it possible to use expressions fortimeout-minutes
:This treats a string like
"10"
as the number10
, which is accepted by the workflow syntax[3].Documentation coverage:
The official [GitHub Expressions Documentation][2][8] describes how expressions are used generally—including in workflow conditions, environment variables, and other parameters—but it does not explicitly document that
timeout-minutes
requires a numeric type or how to use type conversion workarounds.Global/default setting:
Setting
timeout-minutes
in thedefaults
block at the workflow level is not supported; it must be set at the job level. Only keys underdefaults.run
are currently accepted[6][9].In summary:
timeout-minutes
if the result is numeric; ensure type conversion when using variables[3].fromJSON()
for type conversion[3].timeout-minutes
—set per job[6].timeout-minutes
.References for further details:
Citations:
🌐 Web query:
💡 Result:
GitHub Actions expressions do not support a native ternary operator (
? :
) syntax, but you can achieve similar behavior using the&&
and||
logical operators in combination. This pattern is commonly referred to as a "fake ternary" in the GitHub Actions community[1][5][6].Syntax for Ternary-like Expressions
The general syntax is:
${{ condition && value_if_true || value_if_false }}
false
,0
,''
,null
), the result is value_if_false.For example, to conditionally set a parameter based on input:
This adds
--production
ifinputs.production
is'true'
, otherwise adds nothing[1][3].Important Caveats
''
orfalse
)—otherwise the expression will incorrectly fall through to value_if_false even when the condition is true[1][4].'true'
or'false'
as strings for reliable results[3].Chaining Multiple Conditions
You can chain ternary-like expressions for multiple conditions using nested parentheses:
${{ cond1 && result1 || (cond2 && result2 || default_value) }}
This approach is often used for more complex multi-branch logic, such as in
runs-on
or environment variable settings[7]:Or a simpler three-way case:
${{ inputs.app == 'foo' && 'foo-bg-deploy' || ( inputs.app == 'bar' && 'star-bar-bg-deploy' || 'rocket-lite-bg-deploy' )}}
If neither condition is met, the final value (
rocket-lite-bg-deploy
in this example) is selected[7].Combining with
contains
,&&
, and||
You can freely use
contains
,&&
, and||
in these expressions:This example will set
timeout-minutes
to 30 if the branch ismain
, otherwise 10.Summary Table
For advanced logic or if you hit expression complexity limits, you can fall back to a pre-step in a shell script to set the value, then use that value in your step[2][4].
References:
&&
and||
, literal/falsy handling[5][6]Citations:
@ShaharNaveh You're absolutely correct, and I apologize for the misinformation in my original assessment.
The web search confirms that GitHub Actions does support ternary-like expressions using
&&
and||
operators intimeout-minutes
. Your expression${{ contains(matrix.os, 'windows') && 40 || 30 }}
is perfectly valid syntax that will evaluate to 40 minutes for Windows runners and 30 minutes for other OS runners.This is a common pattern in GitHub Actions workflows, often called a "fake ternary" since GitHub Actions doesn't have native ternary operator (
? :
) syntax. The expression works because both 40 and 30 are numeric literals that resolve directly to the expected integer type.Thank you for the correction - the workflow implementation is correct as written.
✏️ Learnings added
🧠 Learnings used