Skip to content

Add type annotations to parser. #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Add type annotations to parser. #597

merged 2 commits into from
Mar 5, 2019

Conversation

windelbouwman
Copy link
Contributor

First of a series of changes to support type annotations.

@codecov-io
Copy link

Codecov Report

Merging #597 into master will decrease coverage by 0.34%.
The diff coverage is 41.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   41.13%   40.78%   -0.35%     
==========================================
  Files          74       74              
  Lines       16880    17034     +154     
  Branches     4450     4491      +41     
==========================================
+ Hits         6944     6948       +4     
- Misses       7907     8053     +146     
- Partials     2029     2033       +4
Impacted Files Coverage Δ
vm/src/stdlib/ast.rs 17.9% <19.04%> (-5.46%) ⬇️
parser/src/ast.rs 22.16% <25%> (-8.91%) ⬇️
vm/src/compile.rs 45.56% <33.33%> (-0.62%) ⬇️
parser/src/parser.rs 46.21% <70.83%> (+2.79%) ⬆️
parser/src/lexer.rs 55.63% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c3f85...f7a2225. Read the comment docs.

@cthulahoops cthulahoops merged commit d278fb8 into master Mar 5, 2019
@windelbouwman windelbouwman deleted the type_hints branch March 23, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants