Apply some clipy lints

RustPython · youknowone · Jul 30, 2025 · Jul 29, 2025 · Jul 29, 2025 · Jul 29, 2025
commit d602a26f831e4c4326b1575659a434b51ae6bd3f
diff --git a/common/src/boxvec.rs b/common/src/boxvec.rs
@@ -165,7 +165,7 @@ impl<T> BoxVec<T> {
         if index >= self.len() {
             None
         } else {
-            self.drain(index..index + 1).next()
+            self.drain(index..=index).next()
         }
     }
 

diff --git a/common/src/format.rs b/common/src/format.rs
@@ -389,7 +389,7 @@ impl FormatSpec {
 
     fn insert_separator(mut magnitude_str: String, inter: i32, sep: char, sep_cnt: i32) -> String {
         let magnitude_len = magnitude_str.len() as i32;
-        for i in 1..sep_cnt + 1 {
+        for i in 1..=sep_cnt {
             magnitude_str.insert((magnitude_len - inter * i) as usize, sep);
         }
         magnitude_str
@@ -754,7 +754,7 @@ impl FormatSpec {
                 let inter = self.get_separator_interval().try_into().unwrap();
                 let len = magnitude_str.len() as i32;
                 let separated_magnitude =
-                    FormatSpec::add_magnitude_separators_for_char(magnitude_str, inter, sep, len);
+                    Self::add_magnitude_separators_for_char(magnitude_str, inter, sep, len);
                 Ok(separated_magnitude)
             }
             None => Ok(magnitude_str),

diff --git a/compiler/codegen/src/compile.rs b/compiler/codegen/src/compile.rs
@@ -360,7 +360,7 @@ impl Compiler {
             fblock: Vec::with_capacity(MAXBLOCKS),
             symbol_table_index: 0, // Module is always the first symbol table
         };
-        Compiler {
+        Self {
             code_stack: vec![module_code],
             symbol_table_stack: Vec::new(),
             source_file,
@@ -380,7 +380,7 @@ impl Compiler {
 
     /// Check if the slice is a two-element slice (no step)
     // = is_two_element_slice
-    fn is_two_element_slice(slice: &Expr) -> bool {
+    const fn is_two_element_slice(slice: &Expr) -> bool {
         matches!(slice, Expr::Slice(s) if s.step.is_none())
     }
 
@@ -882,7 +882,7 @@ impl Compiler {
         self._name_inner(name, |i| &mut i.metadata.names)
     }
     fn varname(&mut self, name: &str) -> CompileResult<bytecode::NameIdx> {
-        if Compiler::is_forbidden_arg_name(name) {
+        if Self::is_forbidden_arg_name(name) {
             return Err(self.error(CodegenErrorType::SyntaxError(format!(
                 "cannot assign to {name}",
             ))));
@@ -3435,7 +3435,7 @@ impl Compiler {
 
         // Create a new tuple of attribute names.
         let mut attr_names = vec![];
-        for name in kwd_attrs.iter() {
+        for name in &kwd_attrs {
             // Py_NewRef(name) is emulated by cloning the name into a PyObject.
             attr_names.push(ConstantData::Str {
                 value: name.as_str().to_string().into(),
@@ -3667,7 +3667,7 @@ impl Compiler {
                                 pc.stores.insert(insert_pos + j, elem);
                             }
                             // Also perform the same rotation on the evaluation stack.
-                            for _ in 0..(i_stores + 1) {
+                            for _ in 0..=i_stores {
                                 self.pattern_helper_rotate(i_control + 1)?;
                             }
                         }
@@ -4547,7 +4547,7 @@ impl Compiler {
             }) => {
                 let prev_ctx = self.ctx;
                 let name = "<lambda>".to_owned();
-                let default_params = Default::default();
+                let default_params = Parameters::default();
                 let params = parameters.as_deref().unwrap_or(&default_params);
 
                 // Prepare defaults before entering function
@@ -4577,7 +4577,7 @@ impl Compiler {
                 let have_kwdefaults = !kw_with_defaults.is_empty();
                 if have_kwdefaults {
                     let default_kw_count = kw_with_defaults.len();
-                    for (arg, default) in kw_with_defaults.iter() {
+                    for (arg, default) in &kw_with_defaults {
                         self.emit_load_const(ConstantData::Str {
                             value: arg.name.as_str().into(),
                         });

diff --git a/compiler/codegen/src/unparse.rs b/compiler/codegen/src/unparse.rs
@@ -464,7 +464,7 @@ impl<'a, 'b, 'c> Unparser<'a, 'b, 'c> {
         if let Some(vararg) = &args.vararg {
             self.unparse_arg(vararg)?;
         }
-        for kwarg in args.kwonlyargs.iter() {
+        for kwarg in &args.kwonlyargs {
             self.p_delim(&mut first, ", ")?;
             self.unparse_function_arg(kwarg)?;
         }