Add return annotation to __annotations__ last
#6071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions like `functools.singledispatch` are sensitive to the order of items in the `__annotations__` map. CPython puts returns last.
WalkthroughThe change updates the Changes
Sequence Diagram(s)sequenceDiagram
participant Compiler
participant Parameters
participant Expr (Return Annotation)
Compiler->>Parameters: Iterate parameter annotations
loop For each parameter
Compiler->>Parameters: Compile annotation
end
alt If return annotation exists
Compiler->>Expr: Compile return annotation
end
Compiler-->>Compiler: Return total annotation count
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Thank you so much! To prevent regression, could you add a test about this? Adding the code described in the issue to |
|
Can do 🫡 |
youknowone
reviewed
Aug 8, 2025
f51bdab to
a04f2f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Functions like
functools.singledispatchare sensitive to the order of items in the__annotations__map. CPython puts return types last.Resolves #6068
Note: I'd prefer to include automated tests from CPython alongside this, but struggled. There are tests from Python 3.13.5's
test_importlib/which will fail without commit, as they make use ofsingledispatchthat would serve to test this code change on every release.Test script
RustPython before
{'return': <class 'int'>, 's': <class 'str'>, }## CPython
{'s': <class 'str'>, 'return': <class 'int'>}RustPython after
{'s': <class 'str'>, 'return': <class 'int'>}Summary by CodeRabbit