Skip to content

Fix ImportError fields #6079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Fix ImportError fields #6079

merged 1 commit into from
Aug 7, 2025
+3 −10

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Aug 7, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Updated internal handling of certain attributes in error messages for improved consistency. No changes to user-facing functionality.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 7, 2025 •
edited
Loading

Walkthrough

The update changes how the "name" and "path" attributes are initialized and stored on PyImportError exception instances. Instead of using attribute setters and initializing them to None, the attributes are now inserted directly into the instance's dictionary during initialization.

Changes

Cohort / File(s) Change Summary
PyImportError Attribute Handling
vm/src/exceptions.rs		 Removed initialization of "name" and "path" to None and switched from set_attr to direct dictionary insertion for these attributes in PyImportError initialization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

In the warren where exceptions hop,
"name" and "path" now take a new stop.
No more setting to None, just a quick dict drop,
Sleek and swift, like a rabbit's hop!
Code grows lighter, bugs may flop—
Onward, bunnies, to the carrot top! 🥕

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93eacda and e0dcc80.

⛔ Files ignored due to path filters (1)
  • Lib/importlib/metadata/__init__.py is excluded by !Lib/**
📒 Files selected for processing (1)
  • vm/src/exceptions.rs (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.rs

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

**/*.rs: Follow the default rustfmt code style (cargo fmt to format)
Always run clippy to lint code (cargo clippy) before completing tasks. Fix any warnings or lints that are introduced by your changes
Follow Rust best practices for error handling and memory management
Use the macro system (pyclass, pymodule, pyfunction, etc.) when implementing Python functionality in Rust

Files:

  • vm/src/exceptions.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Run tests under miri
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
🔇 Additional comments (1)
vm/src/exceptions.rs (1)

1365-1367: Direct dict insertion for ImportError’s name and path is intentional and correct.

In CPython the ImportError’s name and path attributes are initialized by inserting them directly into the instance’s __dict__ via PyDict_SetItemString(), rather than through the generic attribute‐setting machinery. Although other exceptions in vm/src/exceptions.rs use zelf.set_attr(...), matching CPython’s approach here ensures compatibility and performance during exception construction.

• Location: vm/src/exceptions.rs lines 1365–1367

    let dict = zelf.dict().unwrap();
    dict.set_item("name", vm.unwrap_or_none(name), vm)?;
    dict.set_item("path", vm.unwrap_or_none(path), vm)?;

No changes are required.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@youknowone youknowone merged commit 4ae5a1f into RustPython:main Aug 7, 2025
12 checks passed
@youknowone youknowone deleted the importerror branch August 7, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youknowone