Skip to content

Add dict.{keys,values,items} #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Conversation

palaviv
Copy link
Contributor

@palaviv palaviv commented Mar 5, 2019

This implementation should be OK after changing the hashmap to use hash ask key.
This is not yet in compliance with python as this is not a dict view.

@codecov-io
Copy link

Codecov Report

Merging #608 into master will increase coverage by 0.08%.
The diff coverage is 58.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   41.25%   41.34%   +0.08%     
==========================================
  Files          75       75              
  Lines       17096    17121      +25     
  Branches     4538     4540       +2     
==========================================
+ Hits         7053     7078      +25     
+ Misses       8005     8003       -2     
- Partials     2038     2040       +2
Impacted Files Coverage Δ
vm/src/obj/objdict.rs 45.98% <58.53%> (+4.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba25ef...24dcc06. Read the comment docs.

@rmliddle rmliddle merged commit 0000551 into RustPython:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants