Skip to content

Implement type check in member descriptor __set__ #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

Implement type check in member descriptor __set__ #6080

merged 1 commit into from
Aug 8, 2025
+10 −2

Conversation

ever0de
Copy link
Contributor

@ever0de ever0de commented Aug 8, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling when setting member descriptors, ensuring they can only be set on compatible object types. A clear error message is now shown if the descriptor does not apply to the object's class.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 8, 2025 •
edited
Loading

Walkthrough

A subclass check was added to the descr_set method within the PyMemberDescriptor implementation. This ensures that the descriptor can only be set on objects whose class is a subclass of the descriptor's associated type, returning a TypeError otherwise. No public API or signature changes were made.

Changes

Cohort / File(s) Change Summary
Descriptor Subclass Check
vm/src/builtins/descriptor.rs		 Added a subclass verification in PyMemberDescriptor::descr_set to restrict descriptor assignment to compatible object types.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇
A subclass check now guards the door,
Descriptors stray no more!
Only kin may set the field,
TypeErrors stand as shield.
With careful code, the rules are tight—
The bunny hops with pure delight!

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eecef60 and e053914.

⛔ Files ignored due to path filters (1)
  • Lib/test/test_opcache.py is excluded by !Lib/**
📒 Files selected for processing (1)
  • vm/src/builtins/descriptor.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • vm/src/builtins/descriptor.rs
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ever0de ever0de marked this pull request as draft August 8, 2025 05:40
@ever0de
Copy link
Contributor Author

ever0de commented Aug 8, 2025

It looks like the clippy version is set to 1.89 in the CI.

@ever0de ever0de marked this pull request as ready for review August 8, 2025 05:42
@youknowone
Copy link
Member

Thanks! #6082 fixed it.

@ever0de ever0de force-pushed the fix/descriptor-set-type-check branch from eecef60 to e053914 Compare August 8, 2025 06:09
youknowone
youknowone approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... I have no idea what is this spec in python

@youknowone youknowone merged commit e922722 into RustPython:main Aug 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ever0de @youknowone