Skip to content

Update locale.py from 3.13.6 and made _locale available on android #6091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2025
Merged

Update locale.py from 3.13.6 and made _locale available on android #6091

merged 2 commits into from
Aug 20, 2025

Conversation

ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Aug 12, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Enabled locale functionality on Android and other non‑iOS, non‑WASM platforms, expanding availability of locale-aware features.
  • Bug Fixes
    • Adjusted platform exposure of the LC_MESSAGES constant: now available on Unix systems except iOS and Redox, aligning behavior across supported platforms.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 12, 2025 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Lib/test/test__locale.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Relaxed cfg gates to enable the locale module and its initialization on Android (still excluded on iOS and wasm32). In locale.rs, LC_MESSAGES was moved out of the bulk libc import and re-exported under a narrower cfg (unix, not ios/redox), changing its platform exposure.

Changes

Cohort / File(s) Summary of Changes
Module gating and initialization
stdlib/src/lib.rs		 Adjusted cfg from not(any(ios, android, wasm32)) to not(any(ios, wasm32)) for mod locale and its registration in get_module_inits, enabling locale on Android.
Locale constant export refactor
stdlib/src/locale.rs		 Removed LC_MESSAGES from the bulk #[pyattr] use libc::{...} block; reintroduced as a separately gated export #[cfg(all(unix, not(any(target_os = "ios", target_os = "redox"))))] #[pyattr] use libc::LC_MESSAGES;. Reordered remaining constants accordingly.

Sequence Diagram(s)

sequenceDiagram
  participant Runtime
  participant ModuleInit as get_module_inits
  participant Locale as locale (cfg-gated)

  Runtime->>ModuleInit: Build module init list
  alt not(iOS) and not(wasm32)
    ModuleInit->>Locale: Include locale init (Android now included)
  else
    ModuleInit--xLocale: Exclude locale init
  end
  Runtime->>Runtime: Initialize enabled modules
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I twitch my ears at Android’s cheer,
Locale hops in, the path is clear.
LC_MESSAGES peeks—just so, not all—
Unix burrow, no iOS call.
With cfg trails and careful light,
I thump approval: builds feel right. 🐇✨

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

youknowone
youknowone approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 242814f into RustPython:main Aug 20, 2025
21 of 23 checks passed
ever0de pushed a commit to ever0de/RustPython that referenced this pull request Aug 20, 2025
@ShaharNaveh @ever0de
Update locale.py from 3.13.6 and made _locale available on android (
bc52627 
RustPython#6091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaharNaveh @youknowone