Improve readability of methods on PyRef<PyString> #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce PyStringRef type alias - Impl python methods on PyStringRef to allow receiver to just be `self`
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
- Coverage 40.86% 40.86% -0.01%
==========================================
Files 75 75
Lines 17104 17087 -17
Branches 4502 4499 -3
==========================================
- Hits 6990 6983 -7
+ Misses 8123 8114 -9
+ Partials 1991 1990 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason it only occurred to me just now that we don't need the
arbitrary-self-typesrust feature to make the receiver beself. So now it is.This also adds a
PyStringRefalias, sincePyRef<PyString>is a mouthful (and feels more natural given we havePyObjectRef).(What really nice is that this doesn't just make our rust more idiomatic, it's also congruous with python
self.)