Skip to content

Add PyClass. #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2019
Merged

Add PyClass. #625

merged 5 commits into from
Mar 8, 2019

Conversation

cthulahoops
Copy link
Collaborator

Building on top of my other branch to avoid conflicting with myself.

@codecov-io
Copy link

Codecov Report

Merging #625 into master will increase coverage by 0.56%.
The diff coverage is 43.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   40.96%   41.52%   +0.56%     
==========================================
  Files          76       76              
  Lines       17213    17311      +98     
  Branches     4539     4595      +56     
==========================================
+ Hits         7051     7189     +138     
+ Misses       8193     8120      -73     
- Partials     1969     2002      +33
Impacted Files Coverage Δ
vm/src/vm.rs 53.82% <ø> (+0.11%) ⬆️
vm/src/obj/objdict.rs 44.23% <100%> (+0.17%) ⬆️
vm/src/obj/objobject.rs 40.74% <19.04%> (-0.26%) ⬇️
vm/src/obj/objtype.rs 42.5% <35.29%> (-2.47%) ⬇️
vm/src/pyobject.rs 59.83% <50.79%> (-0.31%) ⬇️
vm/src/function.rs 71.73% <0%> (+1.73%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e9029...e220f0a. Read the comment docs.

@cthulahoops
Copy link
Collaborator Author

Thumbs up == okay to merge?

@OddCoincidence
Copy link
Contributor

Yep, looks good to me!

@cthulahoops cthulahoops merged commit 0febcb9 into master Mar 8, 2019
@cthulahoops cthulahoops deleted the py_class branch April 9, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants