Move weakref object type to obj module #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Skinny121 Is this ready now that #635 is merged? (It's still marked draft) |
d533a29 to
7c5be7d
Compare
|
It looks like this just has some irrefutable pattern errors since weakref was the second to last |
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
==========================================
- Coverage 41.02% 40.98% -0.05%
==========================================
Files 77 78 +1
Lines 17558 17588 +30
Branches 4516 4507 -9
==========================================
+ Hits 7204 7208 +4
- Misses 8446 8480 +34
+ Partials 1908 1900 -8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote weakref to be a core type by moving it out of its stdlib module and into the obj module. This is required to implement weakref callbacks, which I will redo in a followup PR. This was originally implemented as part of the outdated #488 PR.
Also, I have migrated the weakref type to use the 'any' payload and new style functions.
I built this on top of #635, so I could use PyRef::new_with_type.