Convert iterator to Any payload #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
- Coverage 40.81% 40.77% -0.05%
==========================================
Files 76 77 +1
Lines 17345 17424 +79
Branches 4474 4487 +13
==========================================
+ Hits 7079 7104 +25
- Misses 8366 8427 +61
+ Partials 1900 1893 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #642 to avoid conflicts.
This is far from ideal because there should actually be a distinct iterator type for each iterable, and the obvious name conflicts with the
PyIteratorextractor. I'm punting on these issues for now, and will straighten things up once the payload conversion is done.