Skip to content

Rename mk_module to make_module. #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Conversation

cthulahoops
Copy link
Collaborator

As discussed in #637.

@codecov-io
Copy link

codecov-io commented Mar 10, 2019

Codecov Report

Merging #651 into master will decrease coverage by 0.01%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #651      +/-   ##
=========================================
- Coverage   41.01%     41%   -0.02%     
=========================================
  Files          78      78              
  Lines       17586   17586              
  Branches     4509    4509              
=========================================
- Hits         7213    7211       -2     
  Misses       8473    8473              
- Partials     1900    1902       +2
Impacted Files Coverage Δ
vm/src/stdlib/platform.rs 0% <0%> (ø) ⬆️
wasm/lib/src/browser_module.rs 0% <0%> (ø) ⬆️
vm/src/stdlib/types.rs 0% <0%> (ø) ⬆️
vm/src/stdlib/random.rs 0% <0%> (ø) ⬆️
vm/src/stdlib/keyword.rs 0% <0%> (ø) ⬆️
vm/src/stdlib/tokenize.rs 0% <0%> (ø) ⬆️
vm/src/stdlib/time_module.rs 0% <0%> (ø) ⬆️
vm/src/stdlib/os.rs 32.09% <100%> (ø) ⬆️
vm/src/stdlib/weakref.rs 12.12% <100%> (ø) ⬆️
vm/src/stdlib/ast.rs 17.69% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf659b8...2449c12. Read the comment docs.

@OddCoincidence OddCoincidence merged commit a48340d into master Mar 11, 2019
@cthulahoops cthulahoops deleted the make_module_not_mk_module branch April 9, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants