Skip to content

Cleaner type_type declaration, and faster instance checking. #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2019

Conversation

cthulahoops
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #658 into master will decrease coverage by 0.04%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   41.05%   41.01%   -0.05%     
==========================================
  Files          78       78              
  Lines       17575    17573       -2     
  Branches     4506     4510       +4     
==========================================
- Hits         7216     7207       -9     
- Misses       8457     8463       +6     
- Partials     1902     1903       +1
Impacted Files Coverage Δ
vm/src/pyobject.rs 58.9% <85.71%> (+0.5%) ⬆️
vm/src/obj/objtype.rs 40.96% <93.33%> (-4.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb24d7...d7e1d69. Read the comment docs.

);
context.set_attr(&type_type, "__doc__", context.new_str(type_doc.to_string()));
context.set_attr(&type_type, "__dir__", context.new_rustfunc(type_dir));
extend_class!(&ctx, &ctx.type_type, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handy stuff!

@windelbouwman windelbouwman merged commit caae69f into master Mar 11, 2019
@cthulahoops cthulahoops deleted the mro branch April 9, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants