Py value into ref #678
Merged
Py value into ref #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16c60d9 to
b204c2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
=========================================
- Coverage 40.33% 40.3% -0.04%
=========================================
Files 79 79
Lines 17488 17503 +15
Branches 4470 4474 +4
=========================================
Hits 7054 7054
- Misses 8588 8603 +15
Partials 1846 1846
Continue to review full report at Codecov.
|
OddCoincidence
approved these changes
Mar 14, 2019
There was a problem hiding this comment.
I like it! This will also make calling python methods from rust more composable given the convention of accepting refs and returning by value, e.g.
let s: PyStringRef;
...
s.upper().into_ref().ends_with(<suffix>)(I do wonder if the Sized bound will be an issue w/ the object representation changes I have brewing, but if so, it's easy enough to split this into another trait with a blanket impl on PyValue)
|
Remember you need a context for into_ref. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #674.
My plan is:
Pushing this push first to make sure we agree on the interface.